[
https://issues.apache.org/jira/browse/HDFS-11406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876926#comment-15876926
]
Andrew Wang commented on HDFS-11406:
------------------------------------
+1 LGTM, thanks for the contribution Alison! Failed tests look unrelated, I'll
commit this shortly.
> Remove unused getStartInstance and getFinalizeInstance in FSEditLogOp
> ---------------------------------------------------------------------
>
> Key: HDFS-11406
> URL: https://issues.apache.org/jira/browse/HDFS-11406
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Andrew Wang
> Assignee: Alison Yu
> Priority: Trivial
> Attachments: HDFS-11406.001.patch
>
>
> Looking at FSEditLogOp, these two methods are unused and can be removed:
> {code}
> static RollingUpgradeOp getStartInstance(OpInstanceCache cache) {
> return (RollingUpgradeOp) cache.get(OP_ROLLING_UPGRADE_START);
> }
> static RollingUpgradeOp getFinalizeInstance(OpInstanceCache cache) {
> return (RollingUpgradeOp) cache.get(OP_ROLLING_UPGRADE_FINALIZE);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
