[ https://issues.apache.org/jira/browse/HDFS-10798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879097#comment-15879097 ]
Andrew Wang commented on HDFS-10798: ------------------------------------ Hi folks, I was looking through the lock logging patches and had a question. I noticed that the read lock and write lock threshold defaults are set differently: {code} public static final String DFS_NAMENODE_WRITE_LOCK_REPORTING_THRESHOLD_MS_KEY = "dfs.namenode.write-lock-reporting-threshold-ms"; public static final long DFS_NAMENODE_WRITE_LOCK_REPORTING_THRESHOLD_MS_DEFAULT = 1000L; public static final String DFS_NAMENODE_READ_LOCK_REPORTING_THRESHOLD_MS_KEY = "dfs.namenode.read-lock-reporting-threshold-ms"; public static final long DFS_NAMENODE_READ_LOCK_REPORTING_THRESHOLD_MS_DEFAULT = 5000L; {code} And I saw this JIRA that made the write lock threshold configurable because it was spamming a lot. Do you think it makes sense to change the write lock default to also be 5000 ms, same as the read lock? I can file a JIRA for this. > Make the threshold of reporting FSNamesystem lock contention configurable > ------------------------------------------------------------------------- > > Key: HDFS-10798 > URL: https://issues.apache.org/jira/browse/HDFS-10798 > Project: Hadoop HDFS > Issue Type: Improvement > Components: logging, namenode > Reporter: Zhe Zhang > Assignee: Erik Krogen > Labels: newbie > Fix For: 2.8.0, 2.7.4, 3.0.0-alpha1 > > Attachments: HDFS-10789.001.patch, HDFS-10789.002.patch > > > Currently {{FSNamesystem#WRITELOCK_REPORTING_THRESHOLD}} is set at 1 second. > In a busy system a lower overhead might be desired. In other scenarios, more > aggressive reporting might be desired. We should make the threshold > configurable. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org