[
https://issues.apache.org/jira/browse/HDFS-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879171#comment-15879171
]
Xiaoyu Yao commented on HDFS-11036:
-----------------------------------
Thanks [~vagarychen] for working on this. The patch looks good to me overall. I
just have a few suggestions below:
*XceiverClientManager.java*
Line 53: Can we use guava CacheBuilder here to simplify the code?
You can refer to the KeyProvdierCache as an example.
Line 63: should be "If a connection has <<not>> been accessed"
Line 108/111: can we use the conf.getTimeDuration() to time related
configuration?
> Ozone : reuse Xceiver connection
> --------------------------------
>
> Key: HDFS-11036
> URL: https://issues.apache.org/jira/browse/HDFS-11036
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-11036-HDFS-7240.001.patch,
> HDFS-11036-HDFS-7240.002.patch, HDFS-11036-HDFS-7240.003.patch
>
>
> Currently for every IO operation calling into XceiverClientManager will
> open/close a connection, this JIRA proposes to reuse connection to reduce
> connection setup/shutdown overhead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
