[ https://issues.apache.org/jira/browse/HDFS-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880364#comment-15880364 ]
Yuanbo Liu edited comment on HDFS-11336 at 2/23/17 12:47 PM: ------------------------------------------------------------- [~umamaheswararao] Thanks for your comments. {quote} instead of accessing name system internals all around, how about block manager talk to name system? {quote} I have two concerns about this point: * Xattr is supposed to work on Inode, not block. Is it good to remove xattr in block manager? * {{BlockStorageMovementAttemptedItems}} is instanced before block manager, if it holds block manager, the value of block manager will always be a null. Currently I don't have an idea about how to get the instanced block manager while removing the xattr. was (Author: yuanbo): [~umamaheswararao] Thanks for your comments. {quote} instead of accessing name system internals all around, how about block manager talk to name system? {quote} I have two concerns about this point: * Xattr is supposed to work on Inode, not block. Is it good to remove in block manager? * {{BlockStorageMovementAttemptedItems}} is instanced before block manager, if it holds block manager, the value of block manager will always be a null. Currently I don't have an idea about how to get the instanced block manager while removing the xattr. > [SPS]: Remove xAttrs when movements done or SPS disabled > -------------------------------------------------------- > > Key: HDFS-11336 > URL: https://issues.apache.org/jira/browse/HDFS-11336 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Reporter: Yuanbo Liu > Assignee: Yuanbo Liu > Attachments: HDFS-11336-HDFS-10285.001.patch, > HDFS-11336-HDFS-10285.002.patch, HDFS-11336-HDFS-10285.003.patch > > > 1. When we finish the movement successfully, we should clean Xattrs. > 2. When we disable SPS dynamically, we should clean Xattrs -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org