[ 
https://issues.apache.org/jira/browse/HDFS-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chen Liang updated HDFS-11036:
------------------------------
    Attachment: HDFS-11036-HDFS-7240.004.patch

Thanks [~anu], [~xyao] and [~eddyxu] for the review and comments!

Uploaded v004 patch. In this patch, the cache has been replaced by a Guava 
cache instance (thanks [~xyao] for the advice and offline discussion). Some 
comments are no longer applicable, while for some others:

{{Could you provide tests for this patch to prove the correctness for the basic 
cases?}}
This is definitely something I would like to have. While this JIRA was mainly 
to unblock other HDFS-7240 JIRAs. Will file separate JIRA, after all the other 
required HDFS-7240 code have been fully checked.

{{I saw you are using container name as key here, would it be an issue if two 
clients / pipelines access the same container at the same time?}}
This is actually the purpose of using cache here: if two clients are accessing 
the same container, they will use the same connection. And "pipeline" is 
actually equal to "container" under the context of this JIRA.

 


> Ozone : reuse Xceiver connection
> --------------------------------
>
>                 Key: HDFS-11036
>                 URL: https://issues.apache.org/jira/browse/HDFS-11036
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>         Attachments: HDFS-11036-HDFS-7240.001.patch, 
> HDFS-11036-HDFS-7240.002.patch, HDFS-11036-HDFS-7240.003.patch, 
> HDFS-11036-HDFS-7240.004.patch
>
>
> Currently for every IO operation calling into XceiverClientManager will 
> open/close a connection, this JIRA proposes to reuse connection to reduce 
> connection setup/shutdown overhead.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to