[ 
https://issues.apache.org/jira/browse/HDFS-11336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886479#comment-15886479
 ] 

Uma Maheswara Rao G commented on HDFS-11336:
--------------------------------------------

I understand your concern and thanks for raising it. My point was not the 
meaning of blkManger to handle namespace info. Keeping delegated API name in 
blkManager as removeXAttr will confuse, I agree.
I was only concerned on accessing namespace functionality in helper classes 
like BlockStorageMovementAttemptedItems. The key class SPS also holding 
namesystem. Is it make sense to delegate there? delighted method name can be 
like SPS#cleanBCTrackingInfo, which can clean Xattrs? Just a thought. What do 
you say [~rakeshr]? 
or Another thought is: SPS can have method called, 
SPS#notifyBlkStorageMovementFinished. This method can clean up required 
resources.


> [SPS]: Remove xAttrs when movements done or SPS disabled
> --------------------------------------------------------
>
>                 Key: HDFS-11336
>                 URL: https://issues.apache.org/jira/browse/HDFS-11336
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Yuanbo Liu
>            Assignee: Yuanbo Liu
>         Attachments: HDFS-11336-HDFS-10285.001.patch, 
> HDFS-11336-HDFS-10285.002.patch, HDFS-11336-HDFS-10285.003.patch
>
>
> 1. When we finish the movement successfully, we should clean Xattrs.
> 2. When we disable SPS dynamically, we should clean Xattrs



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to