[
https://issues.apache.org/jira/browse/HDFS-11417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15888108#comment-15888108
]
Vinayakumar B commented on HDFS-11417:
--------------------------------------
Thanks [~surendrasingh] for the command. It would be a nice addition for admins.
following are some of my comments.
1. To make the naming in sync with Datanode UI, instead of "storage", "volume"
could be used. Like below,
"getStorageReport" --> "getVolumeReport()" to NOT to confuse with namenode's
report.
"DatanodeStorageLocalInfo" --> "DatanodeVolumeInfo" to NOT to confuse with
existing DatanodeStorageInfo.
2. {{Datanode#getStorageReport(..)}} should check for
{{checkSuperuserPrivilege()}}.
3. {{PBHelperClient.convertStorageType(..)}} could be used instead of
{{StorageType.valueOf(proto.getStorageType().toString())}, and vice versa.
4. name could be just {{datanode}}.
{{ClientDatanodeProtocol refreshProtocol = getDataNodeProxy(datanode);}}
5. {{Active Storage(3):}} could be like {{Active Storages : 3}}
6. Write to {{System.out}} instead of {{System.err}}
{code} System.err.println("Active Storage(" + storageReport.size() + "):");
for (DatanodeStorageLocalInfo info : storageReport) {
System.err.println("\n" + info.getDatanodeStorageLocalReport());
}{code}
> Add datanode admin command to get the storage info.
> ---------------------------------------------------
>
> Key: HDFS-11417
> URL: https://issues.apache.org/jira/browse/HDFS-11417
> Project: Hadoop HDFS
> Issue Type: New Feature
> Affects Versions: 2.7.3
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Attachments: HDFS-11417.001.patch, HDFS-11417.002.patch
>
>
> It is good to add one admin command for datanode to get the data directory
> info like storage type, directory path, number of block, capacity, used
> space. This will be help full in large cluster where DN has multiple data
> directory configured.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
