[
https://issues.apache.org/jira/browse/HDFS-11477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891124#comment-15891124
]
Arpit Agarwal commented on HDFS-11477:
--------------------------------------
Thanks for the improvement [~hanishakoneru]. Couple of comments:
# The {{fileIOSamplingFraction == 0}} check may not work. Instead you can check
{{abs(fileIOSamplingFraction) < 0.000001}}. If so, set isEnabled to false.
# Also we can add a check for negative numbers. i.e. if
{{fileIOSamplingFraction < -0.000001}}, log a warning and set isEnabled to
false.
# The documentation in Metrics.md can state this should be a fraction between
0.0 and 1.0, with 0.0 meaning profiling is not enabled.
> Combine FileIO Profiling Enable and Sampling Fraction Config Key into one
> -------------------------------------------------------------------------
>
> Key: HDFS-11477
> URL: https://issues.apache.org/jira/browse/HDFS-11477
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Minor
> Attachments: HDFS-11477.000.patch
>
>
> For Profiling FileIO events, there are 2 keys:
> - DFS_DATANODE_ENABLE_FILEIO_PROFILING_KEY for enabling the hooks
> - DFS_DATANODE_FILEIO_PROFILING_SAMPLING_FRACTION_KEY for setting the
> sampling fraction
> We can instead have only the sampling fraction key and set it to 0 if we want
> to disable profiling.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
