[
https://issues.apache.org/jira/browse/HDFS-11416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892284#comment-15892284
]
Rakesh R commented on HDFS-11416:
---------------------------------
Thanks [~andrew.wang] for the patch. I've few minor comments,
# Please add javadoc for the newly added fnction
{{StringUtils#byteToHexString(byte b)}}
# Please include fail statement for the test case
{{TestStripedINodeFile#testInvalidECPolicy}}
{code}
try{
//.....
//.....
fail("Should throw IllegalArgumentException on invalid ec policy!");
} catch (IllegalArgumentException e) {
GenericTestUtils.assertExceptionContains("Could not find EC policy with" +
" ID 0xbb", e);
}
{code}
> Refactor out system default erasure coding policy
> -------------------------------------------------
>
> Key: HDFS-11416
> URL: https://issues.apache.org/jira/browse/HDFS-11416
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: erasure-coding
> Affects Versions: 3.0.0-alpha1
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Labels: hdfs-ec-3.0-nice-to-have
> Attachments: HDFS-11416.001.patch, HDFS-11416.002.patch,
> HDFS-11416.003.patch, HDFS-11416.004.patch
>
>
> As discussed on HDFS-7859, the system default EC policy is mostly a relic
> from development when the system only supported a single global policy. Now,
> we support multiple policies, and the system default policy is mostly used by
> tests.
> We should refactor to remove this concept.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
