[
https://issues.apache.org/jira/browse/HDFS-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anu Engineer updated HDFS-11196:
--------------------------------
Attachment: HDFS-11196-HDFS-7240.002.patch
[~xyao] Thanks for the comments. I have addressed all comments in the v2 patch.
bq. 1. We seems to have an extra StorageContainerException defined
thanks, fixed.
bq. 2. NIT: StorageContainerException.java
fixed
bq. 295: can we remove the TODO i
done
bq. Line 300: do we need to plumb the traceID
removed.
bq. Line 167/255: NIT: javadoc throws does
fixed one, line 255 not able to find the issue.
bq. Line 293: do we need to throw StorageContainerException with
CONTAINER_INTERNAL_ERROR
not really since we are getting an IO_EXCEPTION from underlying layer.
bq. Line 310: NIT: javadoc throws declaration
fixed
bq. Line 319: can we include the path in the exception message for trouble
shooting?
fixed.
bq. Line 102/107/156/277: throws StorageContainerException
fixed in some locations.
Line 210: should we rethrow StorageContainerException here?
fixed.
bq. Maybe adding more specific PUT_SMALLFILE_ERROR/GET_SMALLFILE_ERROR?
fixed.
> Ozone: Improve logging and error handling in the container layer
> ----------------------------------------------------------------
>
> Key: HDFS-11196
> URL: https://issues.apache.org/jira/browse/HDFS-11196
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-11196-HDFS-7240.001.patch,
> HDFS-11196-HDFS-7240.002.patch
>
>
> Improve logging and error handling in container layer.
> * With this change Storage Containers return StorageContainerException.
> * Precondition checks fail with a human readable error.
> * All failed requests are logged with traceID in the dispatcher.
> * Returns proper error codes for corresponding failures.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
