[
https://issues.apache.org/jira/browse/HDFS-11196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894355#comment-15894355
]
Xiaoyu Yao commented on HDFS-11196:
-----------------------------------
Thanks [~anu] for the update. Patch v002 looks pretty good to me. +1 after the
minor issue below fixed.
TestContainerSmallFile.java Line 66: can we add check for {{cluster != null }}?
{code}
if (cluster != null) {
cluster.shutdown();
}
{code}
This will fix the Jenkins issue like below:
{code}
org.apache.hadoop.ozone.scm.TestContainerSmallFile Time elapsed: 309.379 sec
<<< ERROR!
java.io.IOException: Failed to start MiniOzoneCluster
at
org.apache.hadoop.test.GenericTestUtils.waitFor(GenericTestUtils.java:273)
at
org.apache.hadoop.ozone.MiniOzoneCluster.waitOzoneReady(MiniOzoneCluster.java:160)
at
org.apache.hadoop.ozone.MiniOzoneCluster$Builder.build(MiniOzoneCluster.java:309)
at
org.apache.hadoop.ozone.scm.TestContainerSmallFile.init(TestContainerSmallFile.java:58)
org.apache.hadoop.ozone.scm.TestContainerSmallFile Time elapsed: 309.379 sec
<<< ERROR!
java.lang.NullPointerException: null
at
org.apache.hadoop.ozone.scm.TestContainerSmallFile.shutdown(TestContainerSmallFile.java:66)
{code}
> Ozone: Improve logging and error handling in the container layer
> ----------------------------------------------------------------
>
> Key: HDFS-11196
> URL: https://issues.apache.org/jira/browse/HDFS-11196
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Fix For: HDFS-7240
>
> Attachments: HDFS-11196-HDFS-7240.001.patch,
> HDFS-11196-HDFS-7240.002.patch
>
>
> Improve logging and error handling in container layer.
> * With this change Storage Containers return StorageContainerException.
> * Precondition checks fail with a human readable error.
> * All failed requests are logged with traceID in the dispatcher.
> * Returns proper error codes for corresponding failures.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
