[
https://issues.apache.org/jira/browse/HDFS-11137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weiwei Yang updated HDFS-11137:
-------------------------------
Status: Patch Available (was: Open)
Hi [~anu]
Thank you. I've read the design doc, it was quite helpful. I just uploaded v1
patch, it has following changes
# Moved the code of getting SCM addresses to
{{OzoneClientUtils#getSCMAddresses}} so it can be reused by other places. It
throws IllegalArgumentException if {{OZONE_SCM_NAMES}} is not correctly
configured.
# Added a test in {{TestOzoneClientUtils}} to make sure {{getSCMAddresses}}
works as expected, with both valid or invalid SCM names
# Added a test in {{TestDatanodeStateMachine}} to verify the state machine
transits to SHUTDOWN if invalid SCM names found
Please help to review, thanks
> Ozone: SCM: Add negative tests cases for datanodeStatemachine
> -------------------------------------------------------------
>
> Key: HDFS-11137
> URL: https://issues.apache.org/jira/browse/HDFS-11137
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Weiwei Yang
> Fix For: HDFS-7240
>
> Attachments: HDFS-11137.01.patch
>
>
> This is a jira to track adding negative tests cases for parsing of SCM
> address.
> Do we have unit test for ozone.scm.names like "scm1, scm2:8020, 7.7.7.7:7777"
> This is based on code review comments on HDFS-11081 from Xiaoyu Yao
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
