[ 
https://issues.apache.org/jira/browse/HDFS-11481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897857#comment-15897857
 ] 

Andrew Wang commented on HDFS-11481:
------------------------------------

Hi Mavin, thanks for filing this issue and submitting a patch!

Have you looked at fixing this on the server-side? /.reserved/raw is a 
server-side construct, so it makes more sense to handle it there. Generally, we 
pass the paths through to the NameNode as directly as possible besides 
qualification. Since both /.reserved/raw and .snapshot are "special" 
directories, our path munging might not support both.

Please also [name your patches according to the 
wiki|https://wiki.apache.org/hadoop/HowToContribute#Naming_your_patch] so 
precommit can pick it up correctly.

> hdfs snapshotDiff /.reserved/raw/... fails on snapshottable directories
> -----------------------------------------------------------------------
>
>                 Key: HDFS-11481
>                 URL: https://issues.apache.org/jira/browse/HDFS-11481
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.6.0
>            Reporter: Mavin Martin
>            Assignee: Mavin Martin
>            Priority: Minor
>         Attachments: HDFS-11481.patch.1, HDFS-11481.patch.2
>
>
> Successful command:
> {code}
> #> hdfs snapshotDiff /tmp/dir s1 s2
> Difference between snapshot s1 and snapshot s2 under directory /tmp/dir:
> M       .
> +       ./file1.txt
> {code}
> Unsuccessful command:
> {code}
> #> hdfs snapshotDiff /.reserved/raw/tmp/dir s1 s2
> snapshotDiff: Directory does not exist: /.reserved/raw/tmp/dir
> {code}
> Prefixing with raw path should run successfully and return same output.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to