[
https://issues.apache.org/jira/browse/HDFS-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906074#comment-15906074
]
Anu Engineer commented on HDFS-11469:
-------------------------------------
[~xyao] Thanks for the patch. It looks very good overall. Some very minor
comments.
* Nit: ContainerMapping.java: Line 99: typo: plugable -> pluggable
* Can we make the replication factor an enum instead of int ?
* Nit: We seem to have disabled 3 tests, file a JIRA to track them ?
* Nit: Typo in class name -- *SCMContainerPlacemenRandom*
* In the node placement SCMContainerPlacemenRandom.java:Line 66: Do we need to
make a copy of the lists, Same comment for capacity placement class.
{code}
List<DatanodeID> candidates = new LinkedList<>(healthyNodes);
{code}
> Ozone: SCM: Container allocation based on node report
> -----------------------------------------------------
>
> Key: HDFS-11469
> URL: https://issues.apache.org/jira/browse/HDFS-11469
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-7240
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Attachments: HDFS-11469-HDFS-7240.001.patch
>
>
> The initial patch will make the datanode chosen policy for container creation
> pluggable. It will add at least two built-in policies:
> 1. random (existing)
> 2. utilization of the storage on different data nodes.
> Additional policy based on
> 3. storage type, etc. will be added separately.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
