[
https://issues.apache.org/jira/browse/HDFS-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926887#comment-15926887
]
Arpit Agarwal commented on HDFS-11534:
--------------------------------------
The patch looks good. A few code style suggestions:
# Replace the cascading if-else statements in incrBlocksCounter and
decrBlocksCounter with switch-case.
# incrBlocksInPendingIBR -> rename to incrementBlocksInPendingIBR (avoid
abbreviations).
# Similarly, decrBlocksCounter -> rename to decrementBlocksCounter.
> Add counters for number of blocks in pending IBR
> ------------------------------------------------
>
> Key: HDFS-11534
> URL: https://issues.apache.org/jira/browse/HDFS-11534
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-11534.000.patch
>
>
> IBR can be sent in batch. For the sake of diagnosis, it's helpful to
> understand work load of pending queue, e.g. how many blocks as total, how
> many blocks in status of RECEIVING_BLOCK, RECEIVED_BLOCK, and DELETED_BLOCK,
> respectively. Also the metrics can be exposed to JMX.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
