[
https://issues.apache.org/jira/browse/HDFS-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927391#comment-15927391
]
Xiaoyu Yao commented on HDFS-11537:
-----------------------------------
Thanks [~vagarychen] for working on this and posting the patch. It looks pretty
good to me. I just have few minor issues:
*CBlockConfigKeys.java*
Line 78: is size in GB or MB?
Line 89: Typo in DFS_CBLOCK_CACHE_CHELAN_THRESHOLD_DEFAULT
Line 102-118: As a SCM client, we should use the keys from ScmConfigKeys.
Line 154-161: do we have a JIRA tracking the TODO here?
*AsyncBlockWriter.java*
Line 138: missing javadoc
Line 207: use try {} finally or try-with-resource to ensure the file and and
channel is closed properly if exception is thrown during write.
*CBlockLocalCache.java*
L482/490/...: the rename of the setter parameter name is unnecessary. The
checkstyle rule has exclusion for for setting and constructor.
Line 612: can we track the TODO with a Apache JIRA?
*SyncBlockReader.java*
Line 103: can we use the Hadoop wrapper for the threadpoolexecutor?
Line 244: should we check if the executor is shutdown or not before submit the
task?
*TestLocalBlockCache.java*
Line 97: should we ensure shutdown of xceiverClientManager?
Line 346: should we use try/finally to ensure the cache is closed properly when
exception is thrown during the test?
> Block Storage : add cache layer
> -------------------------------
>
> Key: HDFS-11537
> URL: https://issues.apache.org/jira/browse/HDFS-11537
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Chen Liang
> Assignee: Chen Liang
> Attachments: HDFS-11537-HDSF-7240.001.patch
>
>
> This JIRA adds the cache layer. Specifically, this JIRA implements the cache
> interface in HDFS-11361 and adds the code that actually talks to containers.
> The upper layer can simply view the storage as a cache with simple put and
> get interface, while in the backend the get and put are actually talking to
> containers. This is a critical part to the cblock performance.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
