[
https://issues.apache.org/jira/browse/HDFS-11516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929393#comment-15929393
]
Andrew Wang commented on HDFS-11516:
------------------------------------
LGTM +1 pending a cleaner Jenkins run, thanks for working on this [~lewuathe]!
I think it's okay to change the error code for things like incorrect help
invocations, it's really unlikely that anyone is depending on that.
> Admin command line should print message to stderr in failure case
> -----------------------------------------------------------------
>
> Key: HDFS-11516
> URL: https://issues.apache.org/jira/browse/HDFS-11516
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: HDFS-11516.01.patch, HDFS-11516.02.patch
>
>
> {{AdminHelper}} and {{CryptAdmin}} where prints message to stdout instead of
> stderr. Since other failure cases prints to stderr, it is necessary to
> consolidate that manner.
> e.g.
> {code}
> if (args.size() != 1) {
> System.err.println("You must give exactly one argument to -help.");
> return 0;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
