[ 
https://issues.apache.org/jira/browse/HDFS-1378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032161#comment-13032161
 ] 

Hadoop QA commented on HDFS-1378:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12478890/hdfs-1378.2.txt
  against trunk revision 1102094.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.cli.TestHDFSCLI
                  org.apache.hadoop.hdfs.TestDFSShell
                  org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
                  org.apache.hadoop.hdfs.TestFileConcurrentReader
                  org.apache.hadoop.tools.TestJMXGet

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/487//testReport/
Findbugs warnings: 
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/487//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/487//console

This message is automatically generated.

> Edit log replay should track and report file offsets in case of errors
> ----------------------------------------------------------------------
>
>                 Key: HDFS-1378
>                 URL: https://issues.apache.org/jira/browse/HDFS-1378
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Aaron T. Myers
>             Fix For: 0.23.0
>
>         Attachments: hdfs-1378-branch20.txt, hdfs-1378.0.patch, 
> hdfs-1378.1.patch, hdfs-1378.2.txt
>
>
> Occasionally there are bugs or operational mistakes that result in corrupt 
> edit logs which I end up having to repair by hand. In these cases it would be 
> very handy to have the error message also print out the file offsets of the 
> last several edit log opcodes so it's easier to find the right place to edit 
> in the OP_INVALID marker. We could also use this facility to provide a rough 
> estimate of how far along edit log replay the NN is during startup (handy 
> when a 2NN has died and replay takes a while)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to