[
https://issues.apache.org/jira/browse/HDFS-11358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933495#comment-15933495
]
Anu Engineer commented on HDFS-11358:
-------------------------------------
[~linyiqun] My apologies for the time it took me to get to this JIRA. It looks
pretty good overall. Two small nits.
nit: Command.java: 280
{noformat}
"Please make sure the host file is existed.
Please replace with
"Please make sure the host file exists."
{noformat}
Should we throw an error if nodes is zero ?
{code} String[] nodes = nodeData.split(",");
Collections.addAll(resultSet, nodes);
{code}
> DiskBalancer: Report command supports reading nodes from host file
> ------------------------------------------------------------------
>
> Key: HDFS-11358
> URL: https://issues.apache.org/jira/browse/HDFS-11358
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: diskbalancer
> Affects Versions: 3.0.0-alpha2
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-11358.001.patch
>
>
> This is a improvement of JIRA HDFS-10821. In HDFS-10821, it supports the
> {{diskbalancer report}} command can be executed with multiple nodes. But the
> multiple nodes are read from a nodes string. It will be not good to use when
> the cluster is big enough. A better way we can do is making that can be read
> from a host file as that has been done in many places in HDFS(ex.
> decommission, balancer). This JIRA focus on this point, and will makes this
> done in diskbalancer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
