[ 
https://issues.apache.org/jira/browse/HDFS-6648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15933859#comment-15933859
 ] 

Hudson commented on HDFS-6648:
------------------------------

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11431 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/11431/])
HDFS-6648. Order of namenodes in ConfiguredFailoverProxyProvider is (cdouglas: 
rev b104f3a282ab8e15314446e71189eb3a3b5dd9a6)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ConfiguredFailoverProxyProvider.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSUtilClient.java


> Order of namenodes in ConfiguredFailoverProxyProvider is undefined
> ------------------------------------------------------------------
>
>                 Key: HDFS-6648
>                 URL: https://issues.apache.org/jira/browse/HDFS-6648
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha, hdfs-client
>    Affects Versions: 2.7.0
>            Reporter: Rafal Wojdyla
>            Assignee: Inigo Goiri
>             Fix For: 2.9.0
>
>         Attachments: HDFS-6648-000.patch, HDFS-6648-001.patch
>
>
> In org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider, 
> in the constructor, there's a map <nameservice : < service-id : 
> service-rpc-address > > (DFSUtil.getHaNnRpcAddresses). It's a LinkedHashMap 
> of HashMaps. The order is kept for _nameservices_. Then to find active 
> namenode, for nameservice, we get HashMap of <service-id : 
> service-rpc-address > for requested nameservice (taken from URI request), And 
> for this HashMap we get values - order of this collection is not strictly 
> defined! In the code: 
> {code}
> Collection<InetSocketAddress> addressesOfNns = addressesInNN.values(); 
> {code}
> And then we put these values (in not defined order) into ArrayList of 
> proxies, and then in getProxy we start from first proxy in the list and 
> failover to next if needed. 
> It would make sense for ConfiguredFailoverProxyProvider to keep order of 
> proxies/namenodes defined in hdfs-site.xml.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to