[
https://issues.apache.org/jira/browse/HDFS-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936583#comment-15936583
]
Ewan Higgs commented on HDFS-10675:
-----------------------------------
Looks good. Some minor comments:
# There are checkstyle issues.
# There is some commented out code in {{FsVolumeImpl.java}}
# {{dfs.provided.storageUUID}} has capital letters. It's not common in hadoop
config settings. Notable exceptions are {{fs.defaultFS}} and the various ACL
settings and {{dfs.disk.balancer.max.disk.throughputInMBperSec}}. Maybe this
can just be {{dfs.provided.storage.id}}?
# DFSConfigKeys: should we have a default path in POSIX style or do we need to
keep a semblance of cross platformness with a URI using {{file://}} scheme?
I think this is mostly good for the branch. I'm curious how much work it might
be to tease out some of the {{if (type == provided) return null;}} code into
distinct code policies and if it's worth doing before merging into trunk.
> Datanode support to read from external stores.
> -----------------------------------------------
>
> Key: HDFS-10675
> URL: https://issues.apache.org/jira/browse/HDFS-10675
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Virajith Jalaparti
> Assignee: Virajith Jalaparti
> Attachments: HDFS-10675-HDFS-9806.001.patch,
> HDFS-10675-HDFS-9806.002.patch, HDFS-10675-HDFS-9806.003.patch,
> HDFS-10675-HDFS-9806.004.patch, HDFS-10675-HDFS-9806.005.patch,
> HDFS-10675-HDFS-9806.006.patch
>
>
> This JIRA introduces a new {{PROVIDED}} {{StorageType}} to represent external
> stores, along with enabling the Datanode to read from such stores using a
> {{ProvidedReplica}} and a {{ProvidedVolume}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
