[
https://issues.apache.org/jira/browse/HDFS-11170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937788#comment-15937788
]
SammiChen commented on HDFS-11170:
----------------------------------
Thanks Andrew for the comments. I will upload a new patch based on the
suggestions. I would like to further discuss 2 items.
bq. I recommended earlier to embed the default logic into the getters, since
it lets you avoid doing a separate setDefaultValue call. Any reason not to do
this?
The reason I think is that leave the setDefaultValue right before the create
call to save the unnecessary default value assignment if API caller will call
the specific setter to set the value.
bq. We could probably include this basic functionality test in an existing
testcase to save a minicluster (which takes a few seconds to start and stop)
>From the point that unit tests as example code, would it be better to keep a
>distinct test function, so user can easily find it by refer to the function
>name? Also, I went through the test function name list of
>{{TestDistributedFileSystem}}, all function name carries their target clearly.
> Add create API in filesystem public class to support assign parameter through
> builder
> -------------------------------------------------------------------------------------
>
> Key: HDFS-11170
> URL: https://issues.apache.org/jira/browse/HDFS-11170
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: SammiChen
> Assignee: Wei Zhou
> Labels: hdfs-ec-3.0-nice-to-have
> Attachments: HDFS-11170-00.patch, HDFS-11170-01.patch,
> HDFS-11170-02.patch, HDFS-11170-03.patch, HDFS-11170-04.patch,
> HDFS-11170-05.patch
>
>
> FileSystem class supports multiple create functions to help user create file.
> Some create functions has many parameters, it's hard for user to exactly
> remember these parameters and their orders. This task is to add builder
> based create functions to help user more easily create file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
