[
https://issues.apache.org/jira/browse/HDFS-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Virajith Jalaparti updated HDFS-10675:
--------------------------------------
Attachment: HDFS-10675-HDFS-9806.007.patch
Thanks for the comments, [~ehiggs]. Agree with 1-3. For 4, going with the URI
({{file://}}) scheme seems better. Fixed all of these in the attached patch
(v007).
One way to replace the null checks in the {{StorageDirectory}} can be to use a
builder pattern and create a new {{ProvidedStorageDirectory}} subclass for
{{StorageDirectory}}. This would lead to changes where any constructor for
{{StorageDirectory}} is called (around 40 references). This would still not get
rid of checks that are needed whenever {{getVersionFile}}, {{getCurrentDir}},
{{getPreviousDir}} etc. are called on {{StorageDirectory}}. At least for the
branch, having the checks seems fine. We can re-consider this issue before we
merge into trunk.
> Datanode support to read from external stores.
> -----------------------------------------------
>
> Key: HDFS-10675
> URL: https://issues.apache.org/jira/browse/HDFS-10675
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Virajith Jalaparti
> Assignee: Virajith Jalaparti
> Attachments: HDFS-10675-HDFS-9806.001.patch,
> HDFS-10675-HDFS-9806.002.patch, HDFS-10675-HDFS-9806.003.patch,
> HDFS-10675-HDFS-9806.004.patch, HDFS-10675-HDFS-9806.005.patch,
> HDFS-10675-HDFS-9806.006.patch, HDFS-10675-HDFS-9806.007.patch
>
>
> This JIRA introduces a new {{PROVIDED}} {{StorageType}} to represent external
> stores, along with enabling the Datanode to read from such stores using a
> {{ProvidedReplica}} and a {{ProvidedVolume}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
