[
https://issues.apache.org/jira/browse/HDFS-10629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944302#comment-15944302
]
Chris Douglas commented on HDFS-10629:
--------------------------------------
Very minor feedback on v11:
* {{FederationNamenodeServiceState}} could include all the
{{HAServiceProtocol.HAServiceState}} values, so it can statically check that
they're exhaustive if new states are added
* Will later patches add to {{RouterConfigBuilder}}? If not, it seems vestigial.
* Is the {{Router}} using the {{CompositeService}} abstraction as intended? It
looks like the pattern adds some set of services via {{addService}}, then
follows the lifecycle for a generic service (including starting/stopping
services in order). The patch also combines the {{initService}} and
{{startService}} stages into a single {{initAndStartRouter}} method, called
from {{createRouter}}. The RPC server calls {{addService}} when restarted,
after stopping then re-adding the RPC service.
* {{RemoteLocationContext#getDest}} javadoc is unclear. What is a context
string?
* {{FederationUtil#newInstance}} could be replaced by a combination of
{{Configuration#getClass}} and {{ReflectionUtils#newInstance}} using
{{Configurable}}.
* Some of the APIs returning collections/lists could avoid unintended
dependencies by wrapping in {{Collections#unmodifiableList}}, etc. before
returning to callers.
Overall +1 for committing this to the branch.
> Federation Router
> -----------------
>
> Key: HDFS-10629
> URL: https://issues.apache.org/jira/browse/HDFS-10629
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Inigo Goiri
> Assignee: Jason Kace
> Attachments: HDFS-10629.000.patch, HDFS-10629.001.patch,
> HDFS-10629-HDFS-10467-002.patch, HDFS-10629-HDFS-10467-003.patch,
> HDFS-10629-HDFS-10467-004.patch, HDFS-10629-HDFS-10467-005.patch,
> HDFS-10629-HDFS-10467-006.patch, HDFS-10629-HDFS-10467-007.patch,
> HDFS-10629-HDFS-10467-008.patch, HDFS-10629-HDFS-10467-009.patch,
> HDFS-10629-HDFS-10467-010.patch, HDFS-10629-HDFS-10467-011.patch,
> routerlatency.png
>
>
> Component that routes calls from the clients to the right Namespace.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
