[ 
https://issues.apache.org/jira/browse/HDFS-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032427#comment-13032427
 ] 

Ivan Kelly commented on HDFS-1926:
----------------------------------

One addendum is that I have temporarily put the code to format edits 
directories in FSImage#formatOccurred. I did this because the NNStorageListener 
is not on the streams and these are not created at the time of a format, so 
formatting would not occur. I assume that HDFS-1073 will get rid of these style 
of format anyhow, so once sequential editlog filenames are implemented, this 
can be directly deleted. At this stage NNStorageListener could be reevaluated 
as a lot of it's usefulness will no longer be needed.


> Remove references to StorageDirectory from JournalManager interface
> -------------------------------------------------------------------
>
>                 Key: HDFS-1926
>                 URL: https://issues.apache.org/jira/browse/HDFS-1926
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-1926.diff
>
>
> The JournalManager interface introduced by HDFS-1799 has a 
> getStorageDirectory method which is out of place in a generic interface. This 
> JIRA removed that call by refactoring the error handling for FSEditLog. Each 
> EditLogFileOutputStream is now a NNStorageListener and listens for error on 
> it's containing StorageDirectory. If an error occurs from FSImage, the stream 
> will be aborted. If the error occurs in FSEditLog, the stream will be aborted 
> and NNStorage will be notified that the StorageDirectory is no longer valid.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to