[
https://issues.apache.org/jira/browse/HDFS-11538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950116#comment-15950116
]
Andrew Wang commented on HDFS-11538:
------------------------------------
Thanks for working on this [~HuafengWang] this looks really, really good. I
only have some minor comments:
* Looking through the users of NamenodeProxies, we can remove the method in
DfsServlet that calls it since it's unused.
* NNProxiesClient#createFPP with a proxy factory can be made package private,
no need for VisibleForTesting either.
* Recommend rename HAProxyFactoryClient to ClientHAProxyFactory to unify naming
with NameNodeHAProxyFactory
* Don't need to fix the existing whitespace and checkstyle issues, but we
should at least fix the unused imports from moving code around
I would like to see some client unit tests that show we can instantiate the
failover proxies without a hadoop-hdfs dependency. TestIsMethodSupported looks
like a good place to start.
Unfortunately, we heavily depend on miniclusters for testing, which makes
splitting the unit test suite very challenging. Maybe this can be addressed by
using the shaded minicluster (or lots of mocking), but I think it's too big a
lift to pursue in this change. I still think it'd be a really great follow-on
JIRA though.
> Move ConfiguredFailoverProxyProvider into hadoop-hdfs-client
> ------------------------------------------------------------
>
> Key: HDFS-11538
> URL: https://issues.apache.org/jira/browse/HDFS-11538
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.8.0, 3.0.0-alpha1
> Reporter: Andrew Wang
> Assignee: Huafeng Wang
> Priority: Blocker
> Attachments: HDFS-11538.001.patch
>
>
> Follow-up for HDFS-11431. We should move this missing class over rather than
> pulling in the whole hadoop-hdfs dependency.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
