[
https://issues.apache.org/jira/browse/HDFS-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15951690#comment-15951690
]
Xiaoyu Yao commented on HDFS-11062:
-----------------------------------
Thanks [~yuanbo] for working on this. The patch looks good to me overall. I
just have two questions:
SCMTestMock.java
Line 140: This is related to the ContainerReport handling. Can we simply return
an empty response like you did in Line 197 and remove line 143-158.
The other choice could be wait HDFS-11493 is in before we completely remove the
nullCommand. cc: [~anu] in case he might need the nullCommand for test and
development HDFS-11493.
StorageContainerManager.java
Line 311/505: this will need to change after HDFS-11493.
> Ozone:SCM: Explore if we can remove nullcommand
> -----------------------------------------------
>
> Key: HDFS-11062
> URL: https://issues.apache.org/jira/browse/HDFS-11062
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Yuanbo Liu
> Fix For: HDFS-7240
>
> Attachments: HDFS-11062-HDFS-7240.001.patch
>
>
> in SCM protocol we have a nullCommand that gets returned as the default case.
> Explore if we can remove this.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
