[
https://issues.apache.org/jira/browse/HDFS-11625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956631#comment-15956631
]
Mukul Kumar Singh commented on HDFS-11625:
------------------------------------------
[~cheersyang] This patch looks great and will help in fixing most of the
failures.
I have two minor comments, +1 otherwise.
1)TestCBlockCLI -> there should be a space between the "=" and "null"
{code}
if (cBlockManager !=null) {
{code}
2) TestDataNodeVolumeFailureToleration -> dataDir can be removed as it is not
being accessed anywhere in the code
> Ozone: Fix UT failures that caused by hard coded datanode data dirs
> -------------------------------------------------------------------
>
> Key: HDFS-11625
> URL: https://issues.apache.org/jira/browse/HDFS-11625
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-11625-HDFS-7240.001.patch
>
>
> There seems to be some UT regressions after HDFS-11519, such as
> * TestDataNodeVolumeFailureToleration
> * TestDataNodeVolumeFailureReporting
> * TestDiskBalancerCommand
> * TestBlockStatsMXBean
> * TestDataNodeVolumeMetrics
> * TestDFSAdmin
> * TestDataNodeHotSwapVolumes
> * TestDataNodeVolumeFailure
> these tests set up datanode data dir by some hard coded names, such as
> {code}
> new File(cluster.getDataDirectory(), "data1");
> {code}
> this no longer works since HDFS-11519 changes the pattern from
> {code}
> /data/data<2*dnIndex + 1>
> /data/data<2*dnIndex + 2>
> ...
> {code}
> to
> {code}
> /data/dn0_data0
> /data/dn0_data1
> /data/dn1_data0
> /data/dn1_data1
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
