[
https://issues.apache.org/jira/browse/HDFS-11362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958087#comment-15958087
]
Xiaoyu Yao commented on HDFS-11362:
-----------------------------------
[~hanishakoneru], thanks for reporting the issue and post the fix. The patch
looks good to me overall. I just have one suggestion:
Is it possible to avoid the null check by ensuring that
StorageDirecotry#getStorageDirType never returns null?
For example, we can set a default value of StorageDirectory#dirType to
NameNodeDirType#UNDEFINED if it is not assigned in the constructor?
> Storage#shouldReturnNextDir should check for null dirType
> ---------------------------------------------------------
>
> Key: HDFS-11362
> URL: https://issues.apache.org/jira/browse/HDFS-11362
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Minor
> Attachments: HDFS-11362.000.patch
>
>
> _Storage#shouldReturnNextDir_ method checks if the next Storage directory is
> of the same type us dirType.
> {noformat}
> private boolean shouldReturnNextDir() {
> StorageDirectory sd = getStorageDir(nextIndex);
> return (dirType == null || sd.getStorageDirType().isOfType(dirType)) &&
> (includeShared || !sd.isShared());
> }
> {noformat}
> There is a possibility that sd.getStorageDirType() returns null (default
> dirType is null). Hence, before checking for type match, we should make sure
> that the value returned by sd.getStorageDirType() is not null.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
