[ 
https://issues.apache.org/jira/browse/HDFS-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960077#comment-15960077
 ] 

Kai Zheng commented on HDFS-11623:
----------------------------------

Hi Andrew,

Thanks for your update! I understand your point.

For changes like below, do we need to change it back when user defined policies 
are supported? It's OK for me to have changes like this, and we can later get 
back some of the removed methods like {{getPolicyByID}} for 
ErasureCodingPolicyManager when working on plugin-ed policies.
{code}
@@ -302,7 +303,7 @@ private static ErasureCodingPolicy 
getErasureCodingPolicyForPath(
         if (inode.isFile()) {
           byte id = inode.asFile().getErasureCodingPolicyID();
           return id < 0 ? null :
-              ErasureCodingPolicyManager.getPolicyByID(id);
+              SystemErasureCodingPolicies.getByID(id);
         }
{code}

> Move system erasure coding policies into hadoop-hdfs-client
> -----------------------------------------------------------
>
>                 Key: HDFS-11623
>                 URL: https://issues.apache.org/jira/browse/HDFS-11623
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: HDFS-11623.001.patch, HDFS-11623.002.patch, 
> HDFS-11623.003.patch, HDFS-11623.004.patch
>
>
> This is a precursor to HDFS-11565. We need to move the set of system defined 
> EC policies out of the NameNode's ECPolicyManager into the hdfs-client module 
> so it can be referenced by the client.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to