[ 
https://issues.apache.org/jira/browse/HDFS-11338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962408#comment-15962408
 ] 

Rakesh R commented on HDFS-11338:
---------------------------------

Thanks [~umamaheswararao] for the offline discussions.

IMHO, instead of increasing per test case time out how about an idea to reduce 
the impact of SPS module inclusion. Attached patch is an attempt to change the 
interrupt and thread joining sequence to avoid {{>3secs}} extra waiting period 
for every SPS stop operation. I could see the 
{{TestDFSStripedOutputStreamWithFailure#runTestWithMultipleFailure}} test logic 
is iterating approax 16 times. During each iteration it is calling {{settup}} 
and {{teardown}} functions (which internally does start & stop NN server). 
IIUC, this is adding an extra timed waiting period of 16 * 3secs = 48secs and 
causing some of these test failures.

Lets see the test case improvements in the jenkins.

> [SPS]: Fix timeout issue in unit tests caused by longger NN down time
> ---------------------------------------------------------------------
>
>                 Key: HDFS-11338
>                 URL: https://issues.apache.org/jira/browse/HDFS-11338
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>         Attachments: HDFS-11338-HDFS-10285.00.patch, 
> HDFS-11338-HDFS-10285.01.patch, HDFS-11338-HDFS-10285-02.patch
>
>
> As discussed in HDFS-11186, it takes longer to stop NN:
> {code}
> try {
>   storagePolicySatisfierThread.join(3000);
> } catch (InterruptedException ie) {
> }
> {code}
> So, it takes longer time to finish some tests and this leads to the timeout 
> failures.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to