[
https://issues.apache.org/jira/browse/HDFS-11338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963854#comment-15963854
]
Uma Maheswara Rao G edited comment on HDFS-11338 at 4/11/17 5:29 AM:
---------------------------------------------------------------------
Quick comments:
{code}
* Timed wait to stop storage policy satisfier daemon threads.
+ */
+ public void stopGracefully() {
+ if (sps == null) {
+ sps.stopGracefully();
+ }
+ }
{code}
You should name it as stopSPSGracefully. Because blockmanager#stopGracefully is
stopping sps here, but not block manager stop.
{code}
if (sps == null) {
+ sps.stopGracefully();
+ }
{code}
check should be sps!=null
Other than this comments, changes looks good.
was (Author: umamaheswararao):
Quick comments:
{code}
* Timed wait to stop storage policy satisfier daemon threads.
+ */
+ public void stopGracefully() {
+ if (sps == null) {
+ sps.stopGracefully();
+ }
+ }
{code}
You should name it as stopSPSGracefully. Because blockmanager#stopGracefully is
stopping spa here, but not block manager stop.
{code}
if (sps == null) {
+ sps.stopGracefully();
+ }
{code}
check should be sps!=null
Other than this comments, changes looks good.
> [SPS]: Fix timeout issue in unit tests caused by longger NN down time
> ---------------------------------------------------------------------
>
> Key: HDFS-11338
> URL: https://issues.apache.org/jira/browse/HDFS-11338
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Wei Zhou
> Assignee: Wei Zhou
> Attachments: HDFS-11338-HDFS-10285.00.patch,
> HDFS-11338-HDFS-10285.01.patch, HDFS-11338-HDFS-10285-02.patch,
> HDFS-11338-HDFS-10285-03.patch, HDFS-11338-HDFS-10285-04.patch
>
>
> As discussed in HDFS-11186, it takes longer to stop NN:
> {code}
> try {
> storagePolicySatisfierThread.join(3000);
> } catch (InterruptedException ie) {
> }
> {code}
> So, it takes longer time to finish some tests and this leads to the timeout
> failures.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
