[
https://issues.apache.org/jira/browse/HDFS-11530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965870#comment-15965870
]
Yiqun Lin edited comment on HDFS-11530 at 4/12/17 1:52 PM:
-----------------------------------------------------------
[~vagarychen], thanks a lot for helping fix the related test failure.
The latest patch overall looks good. Now it will be better to let
[~arpitagarwal] to take a look as well.
The units test are not broken now.
I have one thought: we can add the additional test for the special case we are
found when we are working on this JIRA(e.g. node added twice but different
storage type or the exclude node is not DatanodeDescriptor). By completing
this, we can test {{DFSNettopology}} in more different scenarios. BTW, I don't
mean we have to do this in this JIRA since the work of this JIRA is just to
apply {{DFSNettopology}} into default block placement and works well meanwhile .
was (Author: linyiqun):
[~vagarychen], thanks a lot for helping fix the related test failure.
The latest patch overall looks good. Now it will be better to let
[~arpitagarwal] to take a look as well.
The units test are not broken now.
I have one thought: we can add the additional test for the special case when we
are working on this JIRA(e.g. node added twice but different storage type or
the exclude node is not DatanodeDescriptor). By completing this, we can test
{{DFSNettopology}} in more different scenarios. BTW, I don't mean we have to do
this in this JIRA since the work of this JIRA is just to apply
{{DFSNettopology}} into default block placement and works well meanwhile .
> Use HDFS specific network topology to choose datanode in
> BlockPlacementPolicyDefault
> ------------------------------------------------------------------------------------
>
> Key: HDFS-11530
> URL: https://issues.apache.org/jira/browse/HDFS-11530
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 3.0.0-alpha2
> Reporter: Yiqun Lin
> Assignee: Yiqun Lin
> Attachments: HDFS-11530.001.patch, HDFS-11530.002.patch,
> HDFS-11530.003.patch, HDFS-11530.004.patch, HDFS-11530.005.patch,
> HDFS-11530.006.patch, HDFS-11530.007.patch, HDFS-11530.008.patch
>
>
> The work for {{chooseRandomWithStorageType}} has been merged in HDFS-11482.
> But this method is contained in new topology {{DFSNetworkTopology}} which is
> specified for HDFS. We should update this and let
> {{BlockPlacementPolicyDefault}} use the new way since the original way is
> inefficient.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
