[ 
https://issues.apache.org/jira/browse/HDFS-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966707#comment-15966707
 ] 

Anu Engineer commented on HDFS-11569:
-------------------------------------

+1, Thanks for updating this patch and getting this fixed. I am sorry about the 
delay in code review.
I had a very minor comment, you can file another JIRA to fix that if needed. 

In {{getKeyData}}:
{code}
catch (IOException e) {
      throw new IOException("Failed to parse key data from the bytes array.",
          e);
    }
{code}
Should we throw {{StorageContainerException}} here ? 

> Ozone: Implement listKey function for KeyManager
> ------------------------------------------------
>
>                 Key: HDFS-11569
>                 URL: https://issues.apache.org/jira/browse/HDFS-11569
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Weiwei Yang
>            Assignee: Weiwei Yang
>         Attachments: HDFS-11569-HDFS-7240.001.patch, 
> HDFS-11569-HDFS-7240.002.patch, HDFS-11569-HDFS-7240.003.patch, 
> HDFS-11569-HDFS-7240.004.patch, HDFS-11569-HDFS-7240.005.patch, 
> HDFS-11569-HDFS-7240.006.patch, HDFS-11569-HDFS-7240.007.patch
>
>
> List keys by prefix from a container. This will need to support pagination 
> for the purpose of small object support. So the listKey function returns 
> something like ListKeyResult, client can iterate the object to get pagination 
> results.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to