[ 
https://issues.apache.org/jira/browse/HDFS-11604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974095#comment-15974095
 ] 

Lin Zeng commented on HDFS-11604:
---------------------------------

Thanks [Rakesh 
R|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rakeshr] for the 
review!
{quote}
    Please add @InterfaceAudience.Private to public class ECPolicyLoader
{quote}
Sorry about this, I will fix it in next patch.
{quote}
Please combine multiple Java exceptions in the same catch clause like,
{code:java}
    } catch (ParserConfigurationException | IOException | SAXException e) {
      throw new RuntimeException("Failed to load policy file: " + policyFile);
    }
{code}
{quote}
I agree and will follow the approach you suggested.

> Define and parse erasure code codecs, schemas and policies
> ----------------------------------------------------------
>
>                 Key: HDFS-11604
>                 URL: https://issues.apache.org/jira/browse/HDFS-11604
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>            Reporter: Kai Zheng
>            Assignee: Lin Zeng
>             Fix For: 3.0.0-alpha3
>
>         Attachments: ec-config-sample.xml, ec-policy-config-sample-v2.xml, 
> HDFS-11604-v1.patch, HDFS-11604-v2.patch, HDFS-11604-v3.patch, 
> HDFS-11604-v4.patch, HDFS-11604-v5.patch
>
>
> According to recent discussions with [~andrew.wang] in HDFS-7337, it would be 
> good to support allowing users to define their own erasure code codecs, 
> schemas and policies via an XML file. The XML file can be passed to a CLI cmd 
> to parse and send to NameNode to persist and maintain.
> Open this task to define the XML format providing a default sample file to 
> put in the configuration folder for users' reference, and implement the 
> necessary parser utility.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to