[ 
https://issues.apache.org/jira/browse/HDFS-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033219#comment-13033219
 ] 

Jonathan Hsieh commented on HDFS-1787:
--------------------------------------

#2.  Some tabs got in there, reformatting to look like subsequent block blocks.

#3.  Ok, just incrementing the counter in this case, and using the previous 
more verbose message format.

#4. It needs to be a reference to a integer because it is being incremented in 
one thread and read by another. The normal Integer is not really trustable in 
these situations (ends up using a const) so I chose to use AtomicInteger.  In 
the input case, there is only a single thread.  Since this should be a rare 
error condition, I really wouldn't be concerned about its performance.

#5. I believe the string that I use has a different purpose than shipping error 
messages and normally has a node name.  I hijacked it.  This can incur if it is 
not a node name, this can incur ArrayOutOfBounds exception (default value is 
initialized to -1).

More responses pending. 

> "Not enough xcievers" error should propagate to client
> ------------------------------------------------------
>
>                 Key: HDFS-1787
>                 URL: https://issues.apache.org/jira/browse/HDFS-1787
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Jonathan Hsieh
>              Labels: newbie
>             Fix For: 0.23.0
>
>         Attachments: hdfs-1787.patch
>
>
> We find that users often run into the default transceiver limits in the DN. 
> Putting aside the inherent issues with xceiver threads, it would be nice if 
> the "xceiver limit exceeded" error propagated to the client. Currently, 
> clients simply see an EOFException which is hard to interpret, and have to go 
> slogging through DN logs to find the underlying issue.
> The data transfer protocol should be extended to either have a special error 
> code for "not enough xceivers" or should have some error code for generic 
> errors with which a string can be attached and propagated.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to