[
https://issues.apache.org/jira/browse/HDFS-11668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976140#comment-15976140
]
Xiaoyu Yao commented on HDFS-11668:
-----------------------------------
Can we guard the {{LOG.debug(...}} with {{if (LOG.isDebugEnabled())}} since
some of the parameters involve method calls?
+1 after that.
> Ozone: misc improvements for SCM CLI
> ------------------------------------
>
> Key: HDFS-11668
> URL: https://issues.apache.org/jira/browse/HDFS-11668
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Labels: cli, command-line
> Attachments: HDFS-11668-HDFS-7240.001.patch,
> HDFS-11668-HDFS-7240.002.patch, HDFS-11668-HDFS-7240.003.patch
>
>
> Once HDFS-11649 is done, there are some improvements need to be done in order
> to make SCM CLI better to use in a pseudo cluster, this includes
> # HDFS-11649 adds java classes for CLIs, we will need to add shell code to
> expose these commands
> # Better error messages when missing some key ozone configurations, e.g
> {{ozone.scm.names}}, {{ozone.scm.datanode.id}} ... etc
> # Better logging. Currently {{DatanodeStateMachine}} prints very limited
> logs, adds some more logs to indicate state transition is necessary.
> The ultimate goal of this ticket is to ensure SCM CLI can work nicely on a
> pseudo cluster.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
