[ 
https://issues.apache.org/jira/browse/HDFS-11697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982864#comment-15982864
 ] 

Takanobu Asanuma commented on HDFS-11697:
-----------------------------------------

Thanks for the patch, [~lewuathe].

* The javadoc of {{HdfsFileStatus}} constructor also misses the other 
arguments, {{symlink}} and {{childrenNum}}. How about adding javadoc for them?

* This will raise a checkstyle wanrning, "First sentence should end with a 
period."
{code}
/**
 * Get the erasure coding policy if it's set
 * @return the erasure coding policy
 */
{code}
There are five same warnings in other places in this file. Let's fix them.


> Javadoc of erasure coding policy in file status
> -----------------------------------------------
>
>                 Key: HDFS-11697
>                 URL: https://issues.apache.org/jira/browse/HDFS-11697
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Sasaki
>            Assignee: Kai Sasaki
>         Attachments: HDFS-11697.01.patch
>
>
> Though {{HdfsFileStatus}} keeps erasure coding policy, it's not shown in 
> javadoc explicitly as well as storage policy.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to