[ 
https://issues.apache.org/jira/browse/HDFS-10999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984602#comment-15984602
 ] 

Takanobu Asanuma commented on HDFS-10999:
-----------------------------------------

*LowRedundancyBlocks.java:*
Looks like {{corruptReplicatedOneBlocks}} is same as {{corruptReplOneBlocks}}. 
How about reusing {{corruptReplOneBlocks}} instead of calculating 
{{corruptReplicatedOneBlocks}}?

*InvalidateBlocks.java:*
Seems good to me. But as there are many changes in this class, I think we need 
unit tests. If it is not much trouble for you, how about doing 
{{InvalidateBlocks}}-related work as a follow-on task?

> Introduce separate stats for Replicated and Erasure Coded Blocks apart from 
> the current Aggregated stats
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-10999
>                 URL: https://issues.apache.org/jira/browse/HDFS-10999
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: erasure-coding
>    Affects Versions: 3.0.0-alpha1
>            Reporter: Wei-Chiu Chuang
>            Assignee: Manoj Govindassamy
>              Labels: hdfs-ec-3.0-nice-to-have, supportability
>         Attachments: HDFS-10999.01.patch, HDFS-10999.02.patch
>
>
> Per HDFS-9857, it seems in the Hadoop 3 world, people prefer the more generic 
> term "low redundancy" to the old-fashioned "under replicated". But this term 
> is still being used in messages in several places, such as web ui, dfsadmin 
> and fsck. We should probably change them to avoid confusion.
> File this jira to discuss it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to