[
https://issues.apache.org/jira/browse/HDFS-9807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987356#comment-15987356
]
Virajith Jalaparti commented on HDFS-9807:
------------------------------------------
Thanks for posting the modified patch [~ehiggs]. A few comments:
# Is there any particular reason to remove the {{final}} modifiers in
{{DataTransferProtocol#writeBlock}}?
# As {{checkAccess(String[] candidateStorageIds, String[]
storageIdsRequested)}} and {{checkAccess(StorageType[] candidateStorageTypes,
StorageType[] storageTypesRequested)}} in {{BlockTokenSecretManager}}
essentially perform the same function, I think instead of having a new
function, it would be good to have a generic method here.
# It would be good to add an end-to-end test (may be using something like
{{MiniDFSCluster}} to make sure that the correct storage id propagates to the
{{VolumeChoosingPolicy}}.
# Checkstyle issues in {{DataXceiver}}, {{BlockReceiver}} need to be fixed
(unused import, white space issues).
The failed test cases seem to be known flaky tests or pass locally. So, other
than the above comments, the new patch LGTM.
> Add an optional StorageID to writes
> -----------------------------------
>
> Key: HDFS-9807
> URL: https://issues.apache.org/jira/browse/HDFS-9807
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 3.0.0-alpha2
> Reporter: Chris Douglas
> Assignee: Ewan Higgs
> Attachments: HDFS-9807.001.patch, HDFS-9807.002.patch,
> HDFS-9807.003.patch, HDFS-9807.004.patch, HDFS-9807.005.patch,
> HDFS-9807.006.patch
>
>
> The {{BlockPlacementPolicy}} considers specific storages, but when the
> replica is written the DN {{VolumeChoosingPolicy}} is unaware of any
> preference or constraints from other policies affecting placement. This
> limits heterogeneity to the declared storage types, which are treated as
> fungible within the target DN. It should be possible to influence or
> constrain the DN policy to select a particular storage.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
