[ https://issues.apache.org/jira/browse/HDFS-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989242#comment-15989242 ]
Lukas Majercak commented on HDFS-11713: --------------------------------------- None of the findbugs/unit test warnings seem to be related to the change. > Use MoveFileEx to allow renaming a file when the destination exists > ------------------------------------------------------------------- > > Key: HDFS-11713 > URL: https://issues.apache.org/jira/browse/HDFS-11713 > Project: Hadoop HDFS > Issue Type: Bug > Components: hdfs, native, rolling upgrades > Affects Versions: 2.7.1, 2.7.3, 3.0.0-alpha1, 3.0.0-alpha2 > Reporter: Lukas Majercak > Assignee: Lukas Majercak > Labels: windows > Fix For: 3.0.0-alpha2 > > Attachments: HDFS-11713.001.patch > > > The {{NativeIO.c#renameTo0}} currently uses {{MoveFile}} Windows system call, > which fails when renaming a file to a destination that already exists. > This makes the {{TestRollingUpgrade.testRollback}} test fail on Windows, as > during that execution, a DataNode tries to rename block's meta file to a > destination that exists. > The proposal is to change to using {{MoveFileEx}} Windows call, and passing > in {{MOVEFILE_REPLACE_EXISTING}} flag to force the renaming. -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org