[ 
https://issues.apache.org/jira/browse/HDFS-11724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990004#comment-15990004
 ] 

John Zhuge edited comment on HDFS-11724 at 4/29/17 6:37 PM:
------------------------------------------------------------

Patch 001
* posix/thread_local_storage.c includes <stdlib.h> instead of <malloc.h>

Testing done
* Centos 7.2
** Build passed
** hadoop-hdfs-native-client unit tests passed
* Mac
** Build passed
** hadoop-hdfs-native-client unit tests passed except 
<test_test_libhdfs_zerocopy_hdfs_static> due to the known issue that short 
circuit read does not work on Mac (HDFS-3296)



was (Author: jzhuge):
Patch 001
* <posix/thread_local_storage.c> includes <stdlib.h> instead of <malloc.h>

Testing done
* Centos 7.2
** Build passed
** hadoop-hdfs-native-client unit tests passed
* Mac
** Build passed
** hadoop-hdfs-native-client unit tests passed except 
<test_test_libhdfs_zerocopy_hdfs_static> due to the known issue that short 
circuit read does not work on Mac (HDFS-3296)


> libhdfs compilation is broken on OS X
> -------------------------------------
>
>                 Key: HDFS-11724
>                 URL: https://issues.apache.org/jira/browse/HDFS-11724
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 3.0.0-alpha3
>            Reporter: Allen Wittenauer
>            Assignee: John Zhuge
>            Priority: Blocker
>         Attachments: HDFS-11724.001.patch
>
>
> Looks like HDFS-11529 added an include for malloc.h, which isn't available on 
> OS X and likely other operating systems.  Many OSes use sys/malloc.h, 
> including OS X.  But considering this is supposed to be POSIX, then it should 
> be using the define in stdlib.h (as mentioned in pretty much every userland 
> man page on malloc).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to