[ 
https://issues.apache.org/jira/browse/HDFS-11736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991849#comment-15991849
 ] 

Konstantin Shvachko commented on HDFS-11736:
--------------------------------------------

We should instead use something based on {{GenericTestUtils.getTestDir()}} or 
{{GenericTestUtils.getRandomizedTestDir()}}.
For OIV directory in particular we can simply create a directory inside 
NameNode directory, where it actually belongs. 
{{MiniDFSCluster.getNameNodeDirectory()}} is based on {{getTestDir()}} already.

> OIV tests should not write outside 'target' directory.
> ------------------------------------------------------
>
>                 Key: HDFS-11736
>                 URL: https://issues.apache.org/jira/browse/HDFS-11736
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Konstantin Shvachko
>              Labels: newbie++, test
>
> A few tests use {{Files.createTempDir()}} from Guava package, but do not set 
> {{java.io.tmpdir}} system property. Thus the temp directory is created in 
> unpredictable places and is not being cleaned up by {{mvn clean}}.
> This was probably introduced in {{TestOfflineImageViewer}} and then 
> replicated in {{TestCheckpoint}}, {{TestStandbyCheckpoints}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to