[
https://issues.apache.org/jira/browse/HDFS-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992291#comment-15992291
]
Weiwei Yang commented on HDFS-11693:
------------------------------------
Thanks [~anu] for working on this. I have some comments here
*Compressor*
line 69 and line 80 throws rumtime exceptions, they cannot be handled by
callers that has risk to crash the application? I suppose the {{Compressor}}
will be used in datanode when SCM asked it to archive a container, if
{{sourcePath}} or {{tmpPath}} somehow are incorrect, would that crash the
datanode?
line 68: I don't think it is necessary to log an error since it throws an
exception with the same error message here. Same for line 78 in this class and
the constructor of {{Decompressor}}.
line 116: ZipEntry entry = new ZipEntry(file.toString()); Better to use
file.getCanonicalPath()?
*Decompressor*
line 90: if {{getOutputFile}} returns null, seems we are going to continue with
next entry.. does that mean the extracted file is corrupted?
Thanks
> Ozone: Add archive support to containers
> ----------------------------------------
>
> Key: HDFS-11693
> URL: https://issues.apache.org/jira/browse/HDFS-11693
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: HDFS-11693-HDFS-7240.001.patch
>
>
> Add archive support to containers. This is a stepping stone to supporting
> copy containers.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
