[
https://issues.apache.org/jira/browse/HDFS-11695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997430#comment-15997430
]
Uma Maheswara Rao G edited comment on HDFS-11695 at 5/4/17 9:05 PM:
--------------------------------------------------------------------
{quote}
I think LogSync should be outside of both the lock. can you method
FSNameSystem#setStoragePolicy() ?
{quote} Oops you are right. I meant to that. logSync need not have lock.
Add after unLock in fsnamesystem#satisfyStoragePolicy
Regarding #5, I think we can ignore this comment, because this scenario may not
exist. Rakesh reminded me that, we are not doing recursive here. So, don't
change code about this scenario, but please consider adding a test case for it.
Scenario explained in my first comment.
was (Author: umamaheswararao):
{quote}
I think LogSync should be outside of both the lock. can you method
FSNameSystem#setStoragePolicy() ?
{quote} Oops you are right. I meant to that. logSync need not have lock.
Add after unLock in fsnamesystem#satisfyStoragePolicy
Regarding #5, I think we can ignore this comment, because this scenario may not
exist. Ramesh reminded me that, we are not doing recursive here. So, don't
change code about this scenario, but please consider adding a test case for it.
Scenario explained in my first comment.
> [SPS]: Namenode failed to start while loading SPS xAttrs from the edits log.
> ----------------------------------------------------------------------------
>
> Key: HDFS-11695
> URL: https://issues.apache.org/jira/browse/HDFS-11695
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: HDFS-10285
> Reporter: Surendra Singh Lilhore
> Assignee: Surendra Singh Lilhore
> Priority: Blocker
> Attachments: fsimage.xml, HDFS-11695-HDFS-10285.001.patch
>
>
> {noformat}
> 2017-04-23 13:27:51,971 ERROR
> org.apache.hadoop.hdfs.server.namenode.NameNode: Failed to start namenode.
> java.io.IOException: Cannot request to call satisfy storage policy on path
> /ssl, as this file/dir was already called for satisfying storage policy.
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirAttrOp.unprotectedSatisfyStoragePolicy(FSDirAttrOp.java:511)
> at
> org.apache.hadoop.hdfs.server.namenode.FSDirXAttrOp.unprotectedSetXAttrs(FSDirXAttrOp.java:284)
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.applyEditLogOp(FSEditLogLoader.java:918)
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadEditRecords(FSEditLogLoader.java:241)
> at
> org.apache.hadoop.hdfs.server.namenode.FSEditLogLoader.loadFSEdits(FSEditLogLoader.java:150)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
