[
https://issues.apache.org/jira/browse/HDFS-11716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002024#comment-16002024
]
Anu Engineer commented on HDFS-11716:
-------------------------------------
+1 , LGTM. Thank you very much for following up and taking care of this. I
really appreciate it.
I have some minor nits, you don't have to post a new patch to fix those. Can
you please take care of it while committing ? Thanks in advance
* nit: You have a debug print in code -- remove ?
System.out.println(scmPipeline.getContainerName());
* nit: ContainerManagerImpl.java
Delete -> Deleting
* nit: ContainerMapping.java
"Failed delete" -> "Failed to delete"
> Ozone: SCM: CLI: Revisit delete container API
> ---------------------------------------------
>
> Key: HDFS-11716
> URL: https://issues.apache.org/jira/browse/HDFS-11716
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Attachments: HDFS-11716-HDFS-7240.001.patch,
> HDFS-11716-HDFS-7240.002.patch
>
>
> Current delete container API seems can be possibly running into inconsistent
> state. SCM maintains a mapping of container to nodes, datanode maintains the
> actual container's data. When deletes a container, we need to make sure db is
> removed as well as the mapping in SCM also gets updated. What if the datanode
> failed to remove stuff for a container, do we update the mapping? We need to
> revisit the implementation and get these issues addressed. See more
> discussion
> [here|https://issues.apache.org/jira/browse/HDFS-11675?focusedCommentId=15987798&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15987798].
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
