[
https://issues.apache.org/jira/browse/HDFS-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003917#comment-16003917
]
Yiqun Lin commented on HDFS-11783:
----------------------------------
Hi [~cheersyang], thanks for fixing this!
I am thinking we might missing one place in the patch.
{code}
org.apache.hadoop.cblock.meta.VolumeDescriptor.equals(Object) makes inefficient
use of keySet iterator instead of entrySet iterator
{code}
Could you please fix this as well? This warning place is not under ozone but
belong to the feature branch, and will also generate findbugs warning every
time. The fix way has showed above {{use of keySet iterator instead of entrySet
iterator}}.
> Ozone: Fix spotbugs warnings
> ----------------------------
>
> Key: HDFS-11783
> URL: https://issues.apache.org/jira/browse/HDFS-11783
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Reporter: Weiwei Yang
> Assignee: Weiwei Yang
> Labels: findbugs
> Attachments: HDFS-11783-HDFS-7240.001.patch
>
>
> Trunk moves to spotbugs, there might be new warnings in ozone project. This
> task is to track these issues and fix spotbugs warnings. This task is aimed
> to fix the warnings for ozone classes, there is a separate one for rest of
> hdfs in HDFS-11696.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
