[
https://issues.apache.org/jira/browse/HDFS-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009604#comment-16009604
]
Anu Engineer edited comment on HDFS-11769 at 5/14/17 5:47 AM:
--------------------------------------------------------------
[~msingh] Thanks for posting the patch. I have a minor comment about
{{KeySpaceManager.java}}.
* It looks like it has a misplaced line.
{code}
public void join() {
try {
volumeManager.stop();
ksmRpcServer.join();
{code}
Did you intend to write
{code}
public void join() {
try {
ksmRpcServer.join();
volumeManager.stop();
{code}
* Should we read this value to a final member value and use it , instead of
reading from conf all the time ?
{code}
if (prevVolList.size() >= conf.getInt(OZONE_KSM_USER_MAX_VOLUME,
OZONE_KSM_USER_MAX_VOLUME_DEFAULT))
{code}
was (Author: anu):
[~msingh] Thanks for posting the patch. I have a minor comment about
{{KeySpaceManager.java}}. It looks like it has a misplaced line.
{code}
public void join() {
try {
volumeManager.stop();
ksmRpcServer.join();
{code}
Did you intend to write
{code}
public void join() {
try {
ksmRpcServer.join();
volumeManager.stop();
{code}
> Ozone: KSM: Add createVolume API
> --------------------------------
>
> Key: HDFS-11769
> URL: https://issues.apache.org/jira/browse/HDFS-11769
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Mukul Kumar Singh
> Attachments: HDFS-11769-HDFS-7240.001.patch,
> HDFS-11769-HDFS-7240.002.patch, HDFS-11769-HDFS-7240.003.patch
>
>
> Add createVolume API in KSM.
> createVolume API allows administrators to create a volume. The arguments to
> the API are:
> * Admin Name - The name of the administrator who is creating this volume.
> Volumes can be created only by administrators.
> * User Name - The name of the owner of this volume.
> * Quota - Quota information for this volume.
> This JIRA proposes to add the protobuf layer for createVolume and handling in
> KSM. We will file a followup JIRA for the KSM client.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
