[
https://issues.apache.org/jira/browse/HDFS-11769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011020#comment-16011020
]
Anu Engineer commented on HDFS-11769:
-------------------------------------
Excellent work, [~msingh] It looks very good. Thank you very much for getting
this done.
I am also a +1 after the following nits are fixed.
# DistributedStorageHandler.java: replace :
{{.setOwnerName(args.getAdminName())}} ==>
{{.setOwnerName(args.getOwnerName())}}
# KeySpaceManager.java#getClientRpcAddress -- Please remove this function if it
is not used. If we are using it or planning to use it, please fix the comments
and the name of this function.
# KeySpaceManager.java#stop --
{{LOG.info("Volume Manager stop failed.", e);}} ==> {{LOG.info("Key Space
Manager stop failed.", e);}}
# KeySpaceManager.proto: nit: typo:
{{INTERAL_ERROR}} ==> {{INTERNAL_ERROR}}
# KeySpaceManagerProtocolClientSideTranslatorPB.java: nit : typo :
{{implement}} --> {{implementation}}
# MiniOzoneCluster.java#shutdown :
if(ksm != null) check before we call ksm.stop();
# MiniOzoneCluster.java#createKeySpaceManagerClient -- Looks like we are not
using this. if not needed you can remove or if this is needed in future
patches, you might want to consider fixing the comments. The current comments
refer to SCM instead of KSM.
> Ozone: KSM: Add createVolume API
> --------------------------------
>
> Key: HDFS-11769
> URL: https://issues.apache.org/jira/browse/HDFS-11769
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Mukul Kumar Singh
> Attachments: HDFS-11769-HDFS-7240.001.patch,
> HDFS-11769-HDFS-7240.002.patch, HDFS-11769-HDFS-7240.003.patch,
> HDFS-11769-HDFS-7240.004.patch, HDFS-11769-HDFS-7240.005.patch,
> HDFS-11769-HDFS-7240.006.patch, HDFS-11769-HDFS-7240.007.patch
>
>
> Add createVolume API in KSM.
> createVolume API allows administrators to create a volume. The arguments to
> the API are:
> * Admin Name - The name of the administrator who is creating this volume.
> Volumes can be created only by administrators.
> * User Name - The name of the owner of this volume.
> * Quota - Quota information for this volume.
> This JIRA proposes to add the protobuf layer for createVolume and handling in
> KSM. We will file a followup JIRA for the KSM client.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
