[
https://issues.apache.org/jira/browse/HDFS-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013255#comment-16013255
]
Nandakumar commented on HDFS-11775:
-----------------------------------
Thanks for the review [~xyao].
bq. Since most of existing KSM/SCM don't have a separate interface in the
package name, let's keep them together for consistency.
Done
bq. Line 26: need javac doc for the public methods.
Java doc added
bq. Line 71: unused import
Removed unused import
bq. Line 102/110: extra space between public and List
Corrected
bq. Line 161/176: Can we rename this to isVersionEnabled and use simple boolean
instead? If yes, we should make this optional with default=false.
Done
bq. Line 166: we should use the StorageTypeProto defined in hdfs.proto instead
of define a new one StorageType.
Done
bq. Line 181: NIT: suggest rename OzoneACLType to OzoneAclType for consistency.
Done
bq. Line 186: NIT: suggest rename OzoneACLRights to OzoneAclRights for
consistency.
Done
bq. Line 122: you can use thrown.expectMessage to validate the expected
exception.
Done
> Ozone: KSM : add createBucket
> ------------------------------
>
> Key: HDFS-11775
> URL: https://issues.apache.org/jira/browse/HDFS-11775
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: ozone
> Affects Versions: HDFS-7240
> Reporter: Anu Engineer
> Assignee: Nandakumar
> Attachments: HDFS-11775-HDFS-7240.000.patch,
> HDFS-11775-HDFS-7240.001.patch, HDFS-11775-HDFS-7240.002.patch
>
>
> Creates a bucket if it does not exist. A precondition to creating a bucket is
> that a parent volume must exist.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
